Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Yu, Yu-cheng" <yu-cheng.yu@xxxxxxxxx>
Subject: Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
From: Florian Weimer <fweimer@xxxxxxxxxx>
Date: Tue, 01 Sep 2020 19:50:32 +0200
Cc: "H.J. Lu" <hjl.tools@xxxxxxxxx>, Dave Martin <Dave.Martin@xxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, Linux API <linux-api@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Balbir Singh <bsingharora@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Cyrill Gorcunov <gorcunov@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Eugene Syromiatnikov <esyr@xxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Nadav Amit <nadav.amit@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>, Vedvyas Shanbhogue <vedvyas.shanbhogue@xxxxxxxxx>, Weijiang Yang <weijiang.yang@xxxxxxxxx>
In-reply-to: <3c12b6ee-7c93-dcf4-fbf7-2698003386dd@intel.com> (Yu-cheng Yu's message of "Tue, 1 Sep 2020 10:49:01 -0700")
References: <20200825002540.3351-1-yu-cheng.yu@intel.com> <20200825002540.3351-26-yu-cheng.yu@intel.com> <CALCETrVpLnZGfWWLpJO+aZ9aBbx5KGaCskejXiCXF1GtsFFoPg@mail.gmail.com> <2d253891-9393-44d0-35e0-4b9a2da23cec@intel.com> <086c73d8-9b06-f074-e315-9964eb666db9@intel.com> <73c2211f-8811-2d9f-1930-1c5035e6129c@intel.com> <af258a0e-56e9-3747-f765-dfe45ce76bba@intel.com> <ef7f9e24-f952-d78c-373e-85435f742688@intel.com> <20200826164604.GW6642@arm.com> <87ft892vvf.fsf@oldenburg2.str.redhat.com> <20200826170841.GX6642@arm.com> <87tuwow7kg.fsf@oldenburg2.str.redhat.com> <CAMe9rOrhjLSaMNABnzd=Kp5UeVot1Qkx0_PnMng=sT+wd9Xubw@mail.gmail.com> <873648w6qr.fsf@oldenburg2.str.redhat.com> <CAMe9rOqpLyWR+Ek7aBiRY+Kr6sRxkSHAo2Sc6h0YCv3X3-3TuQ@mail.gmail.com> <CAMe9rOpuwZesJqY_2wYhdRXMhd7g0a+MRqPtXKh7wX5B5-OSbA@mail.gmail.com> <3c12b6ee-7c93-dcf4-fbf7-2698003386dd@intel.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

* Yu-cheng Yu:

> Like other arch_prctl()'s, this parameter was 'unsigned long'
> earlier. The idea was, since this arch_prctl is only implemented for
> the 64-bit kernel, we wanted it to look as 64-bit only.  I will change
> it back to 'unsigned long'.

What about x32?  In general, long is rather problematic for x32.

Thanks,
Florian

Follow-Ups:
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Yu, Yu-cheng

References:
- [PATCH v11 00/25] Control-flow Enforcement: Shadow Stack
  - From: Yu-cheng Yu
- [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Yu-cheng Yu
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Andy Lutomirski
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Yu, Yu-cheng
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Dave Hansen
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Yu, Yu-cheng
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Dave Hansen
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Yu, Yu-cheng
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Dave Martin
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Florian Weimer
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Dave Martin
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Florian Weimer
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: H.J. Lu
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Florian Weimer
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: H.J. Lu
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: H.J. Lu
- Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
  - From: Yu, Yu-cheng

Prev by Date: Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
Next by Date: Re: [PATCH v3 23/23] xtensa: use asm-generic/mmu_context.h for no-op implementations
Previous by thread: Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
Next by thread: Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]