On Fri, Apr 24, 2020 at 12:42:00PM -0400, William Breathitt Gray wrote: > Within this patchset the only non-8-bit users are gpio-thunderx and > gpio-xilinix. The gpio-xilinx has configurable port widths so in some > instances it can behave like the 8-bit users, but not always. > > If you want to keep the existing for_each_set_clump8 and related > functions, ignore [PATCH 3/6] and [PATCH 4/6]. That should allow this > patchset to be just an introduction of the new generic functions without > affecting the existing 8-bit users. Yes I don't mind the changes to gpio-thunderx and gpio-xilinx at all but please leave the 8-bit users as they are wherever possible. Actually my concern is not just performance but the existing 8-bit variant is simpler to understand than the generic variant, making it easier to follow the code in the drivers. Thanks, Lukas
