Hi Arnd, On Mon, Jul 1, 2019 at 10:52 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Sat, Jun 29, 2019 at 7:36 AM <guoren@xxxxxxxxxx> wrote: > > > > From: Guo Ren <ren_guo@xxxxxxxxx> > > > > These codes are copied from glibc/string directory, they are the generic > > implementation for string operations. We may further optimize them with > > assembly code in the future. > > > > In fact these code isn't tested enough for kernel, but we've tested them > > on glibc and it seems good. We just trust them :) > > Are these files from the architecture independent portion of glibc or > are they csky specific? If they are architecture independent, we might > want to see if they make sense for other architectures as well, and > add them to lib/ rather than arch/csky/lib/ They are just copied from glibc-2.28/string/*.c and they are generic. OK, I'll try to add them to lib/. > > Should the SPDX identifier list the original LGPL-2.1 license instead > of GPL-2.0? Yes, I removed full Licenses' description: The GNU C Library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version I'll change it to: // SPDX-License-Identifier: LGPL-2.1 -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
