On Sat, Jun 29, 2019 at 7:36 AM <guoren@xxxxxxxxxx> wrote: > > From: Guo Ren <ren_guo@xxxxxxxxx> > > These codes are copied from glibc/string directory, they are the generic > implementation for string operations. We may further optimize them with > assembly code in the future. > > In fact these code isn't tested enough for kernel, but we've tested them > on glibc and it seems good. We just trust them :) Are these files from the architecture independent portion of glibc or are they csky specific? If they are architecture independent, we might want to see if they make sense for other architectures as well, and add them to lib/ rather than arch/csky/lib/ Should the SPDX identifier list the original LGPL-2.1 license instead of GPL-2.0? Arnd