Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.
From: Will Deacon <will.deacon@xxxxxxx>
Date: Wed, 24 Apr 2019 14:50:15 +0100
Cc: Mark Rutland <mark.rutland@xxxxxxx>, Boyang Zhou <zhouby_cn@xxxxxxx>, catalin.marinas@xxxxxxx, haozhu@xxxxxxxxxxx, linux@xxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, arnd@xxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx
In-reply-to: <28023.1556094688@warthog.procyon.org.uk>
References: <20190423170445.GB21047@fuggles.cambridge.arm.com> <1555504525-17962-1-git-send-email-zhouby_cn@126.com> <20190418112818.GA31923@lakrids.cambridge.arm.com> <28023.1556094688@warthog.procyon.org.uk>
User-agent: Mutt/1.11.1+86 (6f28e57d73f2) ()

On Wed, Apr 24, 2019 at 09:31:28AM +0100, David Howells wrote:
> Will Deacon <will.deacon@xxxxxxx> wrote:
> 
> > -		unsigned long, fd, off_t, off)
> > +		unsigned long, fd, off_t, pgoff)
> >  {
> > +	unsigned long off = pgoff;
> > +
> 
> Would loff_t be better?

I don't think so, isn't that still signed? I also think it's the same
size as off_t on arm64 (long long vs long).

Will

References:
- Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.
  - From: Will Deacon
- Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.
  - From: Mark Rutland
- Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.
  - From: David Howells

Prev by Date: Re: [PATCH v2 56/79] docs: Documentation/*.txt: rename all ReST files to *.rst
Next by Date: Re: [PATCH v2 5/5] arm64/speculation: Support 'mitigations=' cmdline option
Previous by thread: Re: [PATCH] The patch solves the type error of the parameter “off” in syscall mmap on the ARM64 platform.
Next by thread: [PATCH v2 00/11] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]