On Sun, Aug 05, 2018 at 10:54:56AM -0500, Rob Landley wrote: > On 08/04/2018 05:51 AM, Matthew Wilcox wrote: > > On Sat, Aug 04, 2018 at 12:47:08PM +0200, Geert Uytterhoeven wrote: > >> You do want to readd the __GFP_ZERO flag to the second user of PGALLOC_GFP, > >> don't you? > > > > I missed that! Probably only relevant for SH-64. But yes ... probably better > > to make this explicit then: > > As far as I know sh5/sh-64 never shipped, it was just some prototype hardware > that didn't go to production? I'm not sure about the details, but GCC has removed support and it's effectively dead. I would be happy to merge patches removing the existing SH-64 stuff in the kernel too. I'm not sure if generality to support LP64 should be left in the arch/sh tree for future or if the eventual 64-bit j-core should just be done as a separate arch tree; I suspect the latter might be cleaner. Rich