On Wed, Jun 7, 2017 at 2:24 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > This is a common problem with the current OF code that numbers INTx from > 1 instead of zero (there is no 5th legacy interrupts in the PCI spec, > despite what $SUBJECT says). I'd be inclined to fix this at the core > level rather than papering over it in the various drivers... While I agree that it's a problem with OF, every other driver has already been changed to paper over the issue. This patch just brings this one remaining OF-PCIe driver to the same level as the others. Without the patch, the driver doesn't work at all if there is a bridge chip on the other end of the controller, so this is not just a hypothetical concern for us. Couldn't the eventual OF fix just refactor this driver along with all of the others? Doing such a sweeping OF change is outside my current comfort zone. I am not familiar enough with the code to understand all the parts that would need to be touched.
