+ Bjorn On 06/06/17 23:59, Palmer Dabbelt wrote: > From: "Wesley W. Terpstra" <wesley@xxxxxxxxxx> > > These are numbered from 1. > > Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx> > --- > drivers/pci/host/pcie-xilinx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c > index 2fe2df51f9f8..8804145d399a 100644 > --- a/drivers/pci/host/pcie-xilinx.c > +++ b/drivers/pci/host/pcie-xilinx.c > @@ -443,7 +443,7 @@ static irqreturn_t xilinx_pcie_intr_handler(int irq, void *data) > val = ((val & XILINX_PCIE_RPIFR1_INTR_MASK) >> > XILINX_PCIE_RPIFR1_INTR_SHIFT) + 1; > generic_handle_irq(irq_find_mapping(port->leg_domain, > - val)); > + val + 1)); > } > } > > @@ -524,7 +524,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port) > return -ENODEV; > } > > - port->leg_domain = irq_domain_add_linear(pcie_intc_node, 4, > + port->leg_domain = irq_domain_add_linear(pcie_intc_node, 5, > &intx_domain_ops, > port); > if (!port->leg_domain) { > This is a common problem with the current OF code that numbers INTx from 1 instead of zero (there is no 5th legacy interrupts in the PCI spec, despite what $SUBJECT says). I'd be inclined to fix this at the core level rather than papering over it in the various drivers... Thanks, M. -- Jazz is not dead. It just smells funny...