On architectures such as ARM, the default location of the kallsyms
data in the rodata section may be problematic, as it then sits right
between the .text and .init.text/.exit.text sections. This is usually
not a problem, but as soon as the code size exceeds a certain threshold,
the linker will start adding trampolines to ensure the two code regions
can reach each other through ordinary relative branches. This causes
inconsistencies between subsequent versions of the kallsyms data,
causing the build to fail.
This adds a Kconfig symbol that, when set, causes the kallsyms data
regions to be moved to the .data section instead, which works around
this problem.
Cc: linux-arch@xxxxxxxxxxxxxxx
Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
---
arch/arm/Kconfig | 1 +
include/asm-generic/vmlinux.lds.h | 12 +++++++++++-
init/Kconfig | 4 ++++
scripts/kallsyms.c | 2 +-
4 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 9f1f09a2bc9b..639e215bd9a1 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -11,6 +11,7 @@ config ARM
select ARCH_USE_BUILTIN_BSWAP
select ARCH_USE_CMPXCHG_LOCKREF
select ARCH_WANT_IPC_PARSE_VERSION
+ select ARCH_HAVE_KALLSYMS_IN_DATA_SECTION
select BUILDTIME_EXTABLE_SORT if MMU
select CLONE_BACKWARDS
select CPU_PM if (SUSPEND || CPU_IDLE)
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 463231d5bfc7..09f93bfaad0e 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -150,6 +150,14 @@
#define TRACE_SYSCALLS()
#endif
+#ifdef CONFIG_ARCH_HAVE_KALLSYMS_IN_DATA_SECTION
+#define KALLSYMS_RODATA
+#define KALLSYMS_DATA *(.kallsyms_data)
+#else
+#define KALLSYMS_RODATA *(.kallsyms_data)
+#define KALLSYMS_DATA
+#endif
+
#define ___OF_TABLE(cfg, name) _OF_TABLE_##cfg(name)
#define __OF_TABLE(cfg, name) ___OF_TABLE(cfg, name)
@@ -197,7 +205,8 @@
LIKELY_PROFILE() \
BRANCH_PROFILE() \
TRACE_PRINTKS() \
- TRACEPOINT_STR()
+ TRACEPOINT_STR() \
+ KALLSYMS_DATA
/*
* Data section helpers
@@ -234,6 +243,7 @@
.rodata : AT(ADDR(.rodata) - LOAD_OFFSET) { \
VMLINUX_SYMBOL(__start_rodata) = .; \
*(.rodata) *(.rodata.*) \
+ KALLSYMS_RODATA \
*(__vermagic) /* Kernel version magic */ \
. = ALIGN(8); \
VMLINUX_SYMBOL(__start___tracepoints_ptrs) = .; \
diff --git a/init/Kconfig b/init/Kconfig
index 058e3671fa11..d6f4920f3487 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1410,6 +1410,10 @@ config KALLSYMS_ALL
Say N unless you really need all symbols.
+config ARCH_HAVE_KALLSYMS_IN_DATA_SECTION
+ bool
+ depends on KALLSYMS
+
config PRINTK
default y
bool "Enable support for printk" if EXPERT
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index c6d33bd15b04..b23682a967e0 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -333,7 +333,7 @@ static void write_src(void)
printf("#define ALGN .align 4\n");
printf("#endif\n");
- printf("\t.section .rodata, \"a\"\n");
+ printf("\t.section .kallsyms_data, \"a\"\n");
/* Provide proper symbols relocatability by their '_text'
* relativeness. The symbol names cannot be used to construct
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
