On 2014-04-22 at 16:24:43 +0200, Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx> wrote: > Hi Ley Foon, > > On Apr 18, Ley Foon Tan wrote: > > +/* > > + * PAGE_SHIFT determines the page size > > + */ > > +#define PAGE_SHIFT 12 > > +#define PAGE_SIZE 4096 > > +#define PAGE_MASK (~(PAGE_SIZE - 1)) > > + > > How about something like this: > > /* PAGE_SHIFT determines the page size */ > #define PAGE_SHIFT 12 > #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) > #define PAGE_MASK (~((1 << PAGE_SHIFT) - 1)) > > Otherwise, the PAGE_SIZE macro above produces some warnings, IIRC. AFAIR old nios2 GCC versions (the 4.1 version from Windriver, IIRC) would complain about something like the above, that's the reason I added an explicit value for PAGE_SIZE back then. I assume with the new nios2 GCC this should no longer be necessary and Ezequiel's fix should be fine. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
