On 07/02/2013 03:19 PM, Geert Uytterhoeven wrote: > On Tue, Jul 2, 2013 at 4:13 AM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote: >> > 'asm-generic' need provide necessary configuration checking, if can't >> > pass checking, 'asm-generic' shouldn't implement it. >> > >> > For 'COMPILE_TEST', according to its help contents, 'asm-generic' need >> > let it pass configuration checking, and provide related dummy contents >> > for it. >> > >> > Part of 'COMPLE_TEST' help contents in "init/Kconfig": >> > >> > "...Despite they cannot be loaded there (or even when they load they cannot be used due to missing HW support)..." >> > >> > >> > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> > NAKed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Please don't clutter the code with checks for CONFIG_COMPILE_TEST. Do you mean: 'asm-generic' should not support 'COMPILE_TEST' (the platform should not support 'COMPILE_TEST") ? Or you mean: 'COMPILE_TEST' should not exist in kernel ? Can we use 'asm-default' instead of 'asm-generic', since "if HW support, it will provide default value, or it will provide nothing" ? Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
