Re: [PATCH v2 0/4] remove GENERIC_GPIO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

On 04/16/2013 04:34 PM, Christian Ruppert wrote:
Thanks for taking a look at the driver. I think the issue we see is due
to the fact that "Platforms must declare GENERIC_GPIO support in their
Kconfig (boolean true)" (from Documentation/gpio.txt). This seems to be
still the case at the moment and I haven't found a way around it.
Removing the config GENERIC_GPIO section from our platform's Kconfig
(see arch/arc/plat-tb10x/Kconfig in linux-next) results in compilation
errors. This seems logical since "config GPIOLIB" only selects
GENERIC_GPIO but assumes it is defined elsewhere.

We were wondering if we could get rid of the "config GENERIC_GPIO"
section in the new platform's Kconfig in order to avoid adding things
you are going to remove again soon and in order to check if there aren't
any hidden dependencies on GENERIC_GPIO in the driver. Do I understand
your mail correctly that this is not yet possible?

Oh, then it looks like *I* did not understand your mail correctly. It is absolutely necessary indeed that your architecture declares a GENERIC_GPIO config option. What I was trying to prevent you from doing was to put new "select GENERIC_GPIO" or "depends on GENERIC_GPIO" in your Kconfig files.

If the only reference to GENERIC_GPIO in your architecture or drivers is the declaration of this config option, then it is perfectly fine - I will take care of removing it when the time is right.

So I guess you guys are just fine - sorry about the misunderstanding!

Thanks,
Alex.

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux