On Wed, Oct 31, 2012 at 5:59 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Wed, 2012-10-31 at 16:13 +0000, James Hogan wrote:
>> Some 32 bit architectures have 64 bit struct alignment (for example
>> metag which has 64 bit read/write instructions). These require 8 byte
>> alignment of event data too, so use CONFIG_HAVE_64BIT_ALIGNED_STRUCT
>> instead of CONFIG_64BIT to decide alignment, and align
>> buffer_data_page::data accordingly.
>
> Can you test if trace-cmd still reads this correctly.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git
>
> Run a simple:
>
> trace-cmd record -e all sleep 2
> trace-cmd report
>
> and make sure that the events report correctly your arch (metag). I just
> want to make sure that it still reads the binary data correctly. I
> should as the /sys/kernel/debug/tracing/events/header_page should
> express the difference in the offset of data.
I just ran trace-cmd on our arch and it appears to work.
# cat /sys/kernel/debug/tracing/events/header_page
field: u64 timestamp; offset:0; size:8; signed:0;
field: local_t commit; offset:8; size:4; signed:1;
field: int overwrite; offset:8; size:1; signed:1;
field: char data; offset:16; size:4080; signed:0;
Does that look ok?
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
