Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
> The DWARF_UNWINDER check is already done in the Kconfig part of this
> patch, so the ifdef here simply seems like a remnant that should have
> been deleted (as the endif was) -- similar to the ARM unwinder case.
No, you still need the #ifdef here.
In the sh/Kconfig you can see this:
select HAVE_MOD_ARCH_SPECIFIC if DWARF_UNWINDER
This says that the arch defines struct mod_arch_specific if
CONFIG_DWARF_UNWINDER is enabled.
If it is not enabled, asm-generic/module.h will emit its own definition of
struct mod_arch_specific which will clash with the one in
arch/sh/include/asm/module.h if the latter is not hidden by the preprocessor.
Note that the ARM unwinder case is the same. In the Kconfig you have:
select HAVE_MOD_ARCH_SPECIFIC if ARM_UNWIND
and in ARM's module.h you have:
#ifdef CONFIG_ARM_UNWIND
enum {
ARM_SEC_INIT,
ARM_SEC_DEVINIT,
ARM_SEC_CORE,
ARM_SEC_EXIT,
ARM_SEC_DEVEXIT,
ARM_SEC_MAX,
};
struct mod_arch_specific {
struct unwind_table *unwind[ARM_SEC_MAX];
};
#endif
(Note I'm quoting from the latest version of the patch which got substantially
reworked).
David
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
