On Thu, Jul 19, 2012 at 11:15:24AM +0930, Rusty Russell wrote:
> On Wed, 18 Jul 2012 14:24:00 +0100, David Howells <dhowells@xxxxxxxxxx> wrote:
> > diff --git a/arch/sh/include/asm/module.h b/arch/sh/include/asm/module.h
> > index b7927de..81300d8b 100644
> > --- a/arch/sh/include/asm/module.h
> > +++ b/arch/sh/include/asm/module.h
> > @@ -1,21 +1,13 @@
> > #ifndef _ASM_SH_MODULE_H
> > #define _ASM_SH_MODULE_H
> >
> > -struct mod_arch_specific {
> > +#include <asm-generic/module.h>
> > +
> > #ifdef CONFIG_DWARF_UNWINDER
> > +struct mod_arch_specific {
> > struct list_head fde_list;
> > struct list_head cie_list;
> > -#endif
> > };
>
> Hmm, this means we get two definitions if CONFIG_DWARF_UNWINDER?
>
> Seems like a useful effort. Fiddly though.
>
The DWARF_UNWINDER check is already done in the Kconfig part of this
patch, so the ifdef here simply seems like a remnant that should have
been deleted (as the endif was) -- similar to the ARM unwinder case.
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
