Re: [PATCH 0/6] get rid of extra check for TASK_SIZE in get_unmapped_area

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 10, 2012 at 07:01:46AM +0400, Vladimir Murzin wrote:
> I was thinking about your suggestion. We are speaking about the same
> problem but different solutions. Let me summarize shortly why I came
> up with current solution:

I don't think there is a problem here.  I think there's just redundant
code in every arch apart from Sparc.

>    * leaving check in arches make them isolated, so
>      mm->get_unmapped_area could be called safely anywhere (currently it
>      is done in hugetlb and get_fb_unmapped_area stuff)

Right.  So is get_fb_unmapped_area() called without first going through
get_unmapped_area() ?  As far as I can see, it isn't.  Same for hugetlbfs.

I don't think you've analysed the issue you are trying to address correctly.
As such I will *not* be giving you an ACK for your current changes to
arch/arm.
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux