On Tuesday 06 March 2012, Mark Salter wrote: > I'm seeing a build failure in lib/string.h in linux-next: > > /es/linux/linux-next/lib/string.c: In function 'strlcat': > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'printk' > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'panic' > > Commit e2950c2b6ecb928bfd3a13dd237df1f29f712704 removed an include of > linux/module.h which triggered the problem for arch/c6x and probably > other architectures using the asm-generic BUG macro. > > I think this needs fixing in asm-generic/bug.h which should include > linux/kernel.h for panic and linux/printk.h for printk. I think you cannot do that as long as linux/kernel.h includes asm/bug.h, or you will get a lot of other build failures. The safer option is probably to add the two missing headers separately to string.c. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html