On Thu, 2011-05-26 at 14:31 +0200, Ingo Molnar wrote: > * Joe Perches <joe@xxxxxxxxxxx> wrote: > > A mis-configured filter can spam the logs with lots of stack traces. > > Rate-limit the warnings and add printout of the bogus filter information. > > Original-patch-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > > --- > > net/core/filter.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/net/core/filter.c b/net/core/filter.c > > index 0eb8c44..0e3622f 100644 > > --- a/net/core/filter.c > > +++ b/net/core/filter.c > > @@ -350,7 +350,9 @@ load_b: > > continue; > > } > > default: > > - WARN_ON(1); > > + WARN_RATELIMIT(1, "Unknown code:%u jt:%u tf:%u k:%u\n", > > + fentry->code, fentry->jt, > > + fentry->jf, fentry->k); > > return 0; > > } > This change (now upstream) fails to build in about 20% of all > randconfigs. Fix is below. We've had problems with ratelimit uses in the past as well. There's a logical separation issue with the #includes of bug.h, printk.h, ratelimit.h kernel.h and the spinlock includes. My suggestion would be to see about again adding #include <linux/ratelimit.h> somehow back to kernel.h which commit 3fff4c42bd0a removed in 2009 because of the spinlock issues. Any suggestion on how best to fix it generically? -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
