* Joe Perches <joe@xxxxxxxxxxx> wrote: > A mis-configured filter can spam the logs with lots of stack traces. > > Rate-limit the warnings and add printout of the bogus filter information. > > Original-patch-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > --- > net/core/filter.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 0eb8c44..0e3622f 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -350,7 +350,9 @@ load_b: > continue; > } > default: > - WARN_ON(1); > + WARN_RATELIMIT(1, "Unknown code:%u jt:%u tf:%u k:%u\n", > + fentry->code, fentry->jt, > + fentry->jf, fentry->k); > return 0; > } This change (now upstream) fails to build in about 20% of all randconfigs. Fix is below. Thanks, Ingo ---------------------> >From b658026bc4915d16ff3e0f59b0edda11dbd6b991 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@xxxxxxx> Date: Thu, 26 May 2011 14:11:14 +0200 Subject: [PATCH] net/core/filter.c: Fix build error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix: net/core/filter.c:353:4: error: invalid storage class for function âDEFINE_RATELIMIT_STATEâ Signed-off-by: Ingo Molnar <mingo@xxxxxxx> --- net/core/filter.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index 0e3622f..36f975f 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -38,6 +38,7 @@ #include <asm/unaligned.h> #include <linux/filter.h> #include <linux/reciprocal_div.h> +#include <linux/ratelimit.h> /* No hurry in this branch */ static void *__load_pointer(const struct sk_buff *skb, int k, unsigned int size) -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
