> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > Sent: Friday, February 18, 2011 6:33 PM > To: Guan Xuetao > Cc: dmitry.torokhov@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arch@xxxxxxxxxxxxxxx; 'Greg KH' > Subject: Re: [PATCH 11/12] unicore32 machine related files: ps2 driver > > On Friday 18 February 2011 11:28:45 Guan Xuetao wrote: > > * Register numbers. > > */ > > -#define I8042_COMMAND_REG ((unsigned long)&PS2_COMMAND) > > -#define I8042_STATUS_REG ((unsigned long)&PS2_STATUS) > > -#define I8042_DATA_REG ((unsigned long)&PS2_DATA) > > +#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND) > > +#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS) > > +#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA) > > + > > +#define I8042_REGION_START (resource_size_t)(&PS2_DATA) > > +#define I8042_REGION_SIZE (resource_size_t)(16) > > It would be better to remove the cast and make the PS2_COMMAND > etc macros have the correct type. Aside from this, the change > looks good. With the patch for __REG in unicore32, following patch could be applied: drivers/input/serio/i8042-unicore32io.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/serio/i8042-unicore32io.h b/drivers/input/serio/i8042-unicore32io.h index 2cdd872..9350843 100644 --- a/drivers/input/serio/i8042-unicore32io.h +++ b/drivers/input/serio/i8042-unicore32io.h @@ -29,11 +29,11 @@ /* * Register numbers. */ -#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND) -#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS) -#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA) +#define I8042_COMMAND_REG PS2_COMMAND +#define I8042_STATUS_REG PS2_STATUS +#define I8042_DATA_REG PS2_DATA -#define I8042_REGION_START (resource_size_t)(&PS2_DATA) +#define I8042_REGION_START (resource_size_t)(PS2_DATA) #define I8042_REGION_SIZE (resource_size_t)(16) static inline int i8042_read_data(void) > > Arnd Thanks & Regards. Guan Xuetao -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
