> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > Sent: Friday, February 18, 2011 1:40 AM > To: Guan Xuetao > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-arch@xxxxxxxxxxxxxxx; 'Greg KH' > Subject: Re: [PATCH 08/12] unicore32 machine related files: core files > > On Wednesday 16 February 2011, Guan Xuetao wrote: > > Message-Id: <15f7e89c92883a77c96f5f3288c9a4afbd68f8e3.1297842537.git.gxt@xxxxxxxxxxxxxxx> > > In-Reply-To: <cover.1297842537.git.gxt@xxxxxxxxxxxxxxx> > > References: <cover.1297842537.git.gxt@xxxxxxxxxxxxxxx> > > From: GuanXuetao <gxt@xxxxxxxxxxxxxxx> > > Date: Sat, 15 Jan 2011 18:24:16 +0800 > > These headers should not be here. When using git-send-email, this will be handled > automatically, but if you send the patch from a regular email client application, > you should remove them manually. > > > diff --git a/arch/unicore32/Kconfig.puv3 b/arch/unicore32/Kconfig.puv3 > > new file mode 100644 > > index 0000000..2ef10db > > --- /dev/null > > +++ b/arch/unicore32/Kconfig.puv3 > > @@ -0,0 +1,125 @@ > > +# > > +# PKUnity v3 Kconfig > > +# > > + > > +if ARCH_PUV3 > > + > > +menu "PKUnity v3 SoC Features" > > + > > +config PUV3_I2C > > + bool "PKUnity v3 I2C bus support" > > +# default y > > + select I2C > > + select I2C_CHARDEV > > + select I2C_ALGOBIT > > + > > +config PUV3_UMAL > > + tristate "PKUnity v3 UMAL Gigabit Network Adapter support" > > + select MII > > + select PHYLIB > > ... > > Generally, everything in this file should be moved to other files. > The rule is that the Kconfig entry belongs into the same directory > as the Makefile referencing it. E.g. the two above should > be in drivers/i2c/busses/Kconfig and drivers/net/Kconfig, and in > the same patch as the actual device driver. > > > + > > +static struct platform_device nb0916_device_gpio_button = { > > + .name = "gpio-keys", > > + .id = -1, > > + .dev = { > > + .platform_data = &nb0916_gpio_button_data, > > + }, > > +}; > > + > > +static struct platform_device *mach_nb0916_devices[] __initdata = { > > + &puv3_device_i2c, > > + &physmap_flash, > > + &nb0916_device_backlight, > > + &nb0916_device_gpio_button, > > +}; > > Static platform devices are no longer recommended. You can change these > to use platform_device_register_simple() or a variant of it. > > If you plan to convert the entire architecture to use a flattened > device tree as we discussed in an earlier review, you don't need to > bother with this now, because the entire platform device registration > you have here can then be removed. Above two files are no used in new reviewed version, and they were removed. > > Arnd Thanks Arnd Guan Xuetao -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
