On Tue, Nov 30, 2010 at 04:20:50PM -0800, Luck, Tony wrote: > Here's version 2 with most of the fixes suggested in the discussion > for version 1 (see http://marc.info/?l=linux-arch&m=129045078803118&w=2). > > Stuff that I haven't done: > > 1) Still has the "daft" echo filename > erase to clear entries from the > persistent store. I looked hard at /sys and can't see how to get a > notification for an unlink(2). If I'm missing something, would somebody > please send me a clue. If this is a fatal flaw - then this will have to > move to debugfs (or turn into its own filesystem type). But I'd really > prefer to not give up the convenience of /sys > > 2) Did not implement Jim's suggestion to save OOPs ... I'm not at > all sure how to let the user configure this. mtdoops.c has a module > parameter for it - but I gave up on letting pstore be a module ... > it needs to be initialized before the platform driver, and there doesn't > seem to be much point in having it be unloadable. > > I did write the ERST platform hooks (they are part 2 of 2, but I'd advise > the faint of heart not to look too closely at the ACPI/APEI'isms involved). > Here's a sample of what it looks like (with a debug call to panic() from > the pstore_erase() function added for testing purposes): > > $ cd /sys/firmware/pstore As you are adding new sysfs files, you are required to document them in Documentation/ABI/ as well. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
