Re: [GPIO]implement sleeping GPIO chip removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Can you please use a mail client which does proper line breaks at 78 ?

On Wed, 10 Nov 2010, Maciej Szmigiero wrote:
> You misunderstood me.

No, I didnt.

> By "looping in hope that somebody will finally release the chip" I
> meant the only real way to handle a GPIO chip unplugging in the
> current kernel.  Which is way worse that preventing new requests,
> then waiting for existing one to be released.  And this is exactly
> what my patch does.

That still does not make it a good solution.

> I understand that it could be simplified by removing redundant code
> (as Grant Likely had suggested before), and moving it to completion
> interface instead of manipulating a task structure directly, but
> this doesn't mean that the whole GPIO code has to be rewritten just
> to add one functionality.

It's not about rewriting, it's about fixing the problem in the right
way and not just hacking around it.

If we see a shortcoming like this, we fix it and do not magically work
around it.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux