On Mon, Oct 18, 2010 at 04:45:12PM +0200, Arnd Bergmann wrote: > Note that patches 20 and 22 of the series completely eliminate the > the minix and ext2 definitions, putting them into architecture independent > code in those two file systems where they belong. Good. > Adding the new definitions in patch 4 is just a logical step before removing > the old definitions in the later patches while maintaining bisectability. In which case I don't have a problem with the series. > > What I'm trying to say is please don't make the existing mess of bitops > > any worse than it currently is. > > The series currently adds 20 lines to the arm code (could be reduced to > 6 lines), but removes 26 lines which are essentially architecture > independent and shouldn't be there to start with. I'd call that the > opposite of making the mess worse. Right - if I could've seen the rest of the series, then maybe I'd have known that. However, I seemed to have silently dropped off linux-arch back in April and only just noticed, which means I've missed rather a lot... -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html