On 7/3/2010 5:00 AM, Arnd Bergmann wrote: > On Friday 02 July 2010 22:48:17 Matthew Wilcox wrote: > >> I wouldn't mind seeing kvm_types.h, rwlock_types.h and spinlock_types.h >> merged into types.h, personally. They're all pretty fundamental kernel >> kind of types. It's a matter of taste, and I'm not particularly fussed >> one way or the other. >> >> mm_types.h is complex and full of mm-specific information, so keeping >> it separate makes sense to me. >> >> I just object to the unnecessary creation of tiny files like this. >> Which is how we ended up with atomic_t and atomic64_t in there in the >> first place :-) >> > Ah, I didn't notice you had moved the atomic types in there. I agree that > the list types are in the same general category and it makes sense > to treat them the same way. > > For rwlock_types.h and spinlock_types.h, I think including them in types.h > would really cause too much other crap to be pulled in through lockdep > and other things we might need in there in the future, which would in turn > cause the same problems with types.h that Chris is trying to avoid > in the first place by moving stuff out of list.h. > Sounds like we have a consensus on moving the list_head, hlist_head, and hlist_node types to <linux/types.h>. I assume everyone is agreed that initializers, etc., should stay in <linux/list.h>. I will send out a revised git patch on Sunday. -- Chris Metcalf, Tilera Corp. http://www.tilera.com -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
