Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
From: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
Date: Mon, 6 Jan 2025 15:35:09 +0100
Cc: peterz@xxxxxxxxxxxxx, kevin.brodsky@xxxxxxx, palmer@xxxxxxxxxxx, tglx@xxxxxxxxxxxxx, david@xxxxxxxxxx, jannh@xxxxxxxxxx, hughd@xxxxxxxxxx, yuzhao@xxxxxxxxxx, willy@xxxxxxxxxxxxx, muchun.song@xxxxxxxxx, vbabka@xxxxxxxxxx, lorenzo.stoakes@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, rientjes@xxxxxxxxxx, vishal.moola@xxxxxxxxx, arnd@xxxxxxxx, will@xxxxxxxxxx, aneesh.kumar@xxxxxxxxxx, npiggin@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, rppt@xxxxxxxxxx, ryan.roberts@xxxxxxx, linux-mm@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-openrisc@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx
In-reply-to: <57ea8193-2fd9-41a9-85b4-7af924f900f4@bytedance.com>
References: <cover.1735549103.git.zhengqi.arch@bytedance.com> <ad21b9392096336cf15aee46f68f9989a9cf877e.1735549103.git.zhengqi.arch@bytedance.com> <Z3uyJ2BjslzsjkZI@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com> <2d16f0fe-9c7f-4229-b7b5-ffa3ab1b1143@bytedance.com> <Z3vQHplZqtHf6Td8@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com> <57ea8193-2fd9-41a9-85b4-7af924f900f4@bytedance.com>

On Mon, Jan 06, 2025 at 09:34:55PM +0800, Qi Zheng wrote:
> OK, will change the subject and description to:
> 
> s390: pgtable: also move pagetable_dtor() of PxD to pagetable_dtor_free()
> 
> To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of
> PMD|PUD|P4D to pagetable_dtor_free().
> 
> But pagetable_dtor_free() is newly introduced in this patch, should it
> be changed to 'move ... to pagetable_pte_dtor_free()'? But this seems
> strange. :(

s390: pgtable: consolidate PxD and PTE TLB free paths

Call pagetable_dtor() for PMD|PUD|P4D tables just before ptdesc is
freed - same as it is done for PTE tables. That allows consolidating
TLB free paths for all table types.

Makes sense?

> Thanks!

Thank you!

Follow-Ups:
- Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
  - From: Qi Zheng

References:
- [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table()
  - From: Qi Zheng
- [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
  - From: Qi Zheng
- Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
  - From: Alexander Gordeev
- Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
  - From: Qi Zheng
- Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
  - From: Alexander Gordeev
- Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
  - From: Qi Zheng

Prev by Date: Re: [PATCH v4 06/15] s390: pgtable: add statistics for PUD and P4D level page table
Next by Date: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
Previous by thread: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
Next by thread: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]