On Mon, Jan 06, 2025 at 07:02:17PM +0800, Qi Zheng wrote: > > On Mon, Dec 30, 2024 at 05:07:47PM +0800, Qi Zheng wrote: > > > To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of > > > PMD|PUD|P4D to __tlb_remove_table(). > > > > The above and Subject are still incorrect: pagetable_dtor() is > > called from pagetable_dtor_free(), not from __tlb_remove_table(). > > Hmm, __tlb_remove_table() calls pagetable_dtor_free(), so moving to > pagetable_dtor_free() means moving to __tlb_remove_table(). Right? Right. But you Subject and description claim "... also move the pagetable_dtor()" not to pagetable_dtor_free() - which is another function. > And the main purpose of this patch is also to move pagetable_dtor() > to __tlb_remove_table(). So I think this description makes sense? The patch makes sense, but the description it is incorrect ;) Thanks!
