On Fri, Feb 12, 2010 at 08:21:33AM -0800, Linus Torvalds wrote: > On Fri, 12 Feb 2010, Kyle McMartin wrote: > > Mike Frysinger pointed out that calling tracehook_signal_handler with > > stepping=0 missed testing the thread flags, resulting in not calling > > ptrace_notify. Fix this by testing if we're single stepping or branch > > stepping and setting the flag accordingly. > > > > Tested, seems to work. > > Hmm. All other architectures either pass in zero, or test TIF_SINGLESTEP. > > I guess TIF_BLOCKSTEP is a parisc addition, so now parisc matches x86 and > power etc, but it still makes me wonder about all those other > architectures that pass in zero. > > For the curious, that seems to be at least sparc and 64-bit (but not > 32-bit) sh. > > David? Paul? > It's a legitimate bug on sh64. We support hardware single stepping there but never tied in the thread flags when the code was merged with 32-bit, so this behaviour has existed for some time. I'll fix it up and send out patches as soon as I get a chance to test it. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
