On Friday 12 February 2010 11:21:33 Linus Torvalds wrote: > On Fri, 12 Feb 2010, Kyle McMartin wrote: > > Mike Frysinger pointed out that calling tracehook_signal_handler with > > stepping=0 missed testing the thread flags, resulting in not calling > > ptrace_notify. Fix this by testing if we're single stepping or branch > > stepping and setting the flag accordingly. > > > > Tested, seems to work. > > Hmm. All other architectures either pass in zero, or test TIF_SINGLESTEP. > > I guess TIF_BLOCKSTEP is a parisc addition, so now parisc matches x86 and > power etc, but it still makes me wonder about all those other > architectures that pass in zero. > > For the curious, that seems to be at least sparc and 64-bit (but not > 32-bit) sh. > > David? Paul? David said that the sparc code is currently correct as hardware single stepping is not supported: http://lkml.org/lkml/2010/2/11/385 -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
