Re: problems in commit 2d4dc890b5c8 (block: add helpers to run flush_dcache_page() against a bio and a request's pages)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 10 Dec 2009 16:00:18 -0600

> On Fri, 2009-12-11 at 00:27 +0300, Ilya Loginov wrote:
>> On Thu, 10 Dec 2009 14:59:36 -0600
>> James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
>> 
>> > To fix mips, you just need a
>> > flush_kernel_dcache_page() in slram_read so that the alias is updated
>> > after the memcpy. 
>> 
>> I think you right. But! If we choose this way:
>> 
>> First. We need to realize flush_kernel_dcache_page() for many
>> architectures. Am I right?
> 
> Actually, I think only sparc and mips need it.  It's only needed for an
> aliasing architecture.  Next, it's only used for pio drivers, so if the
> platform never uses a pio driver, it can get away without having this
> (that's the sparc case, I think).

Sparc has PIO drivers, namely IDE, and we have special flushes inserted
into the IDE string PIO routines to handle that case.
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux