On Thu, 10 Dec 2009 14:59:36 -0600 James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > To fix mips, you just need a > flush_kernel_dcache_page() in slram_read so that the alias is updated > after the memcpy. I think you right. But! If we choose this way: First. We need to realize flush_kernel_dcache_page() for many architectures. Am I right? Second. What difference will be between flush_kernel_dcache_page and flush_dcache_page on MIPS? In common, flush_dcache_page in MIPS set bit dirty on page. > I would also expect this driver not to work on any > highmem system without additional kmap/kunmap(_atomic) pairs in the read > and write routines. > How many other mtd drivers are affected, I'm not sure ... any that do > PIO are wrong ... those that do MMIO should be right (that looks to be > just the omap driver). Third. We should fix all other PIO drivers with problem and patch aoe: switch to the new bio_flush_dcache_pages() interface in -mm tree (i can't find this commit in the Linus tree). There is same problem. May be I wrong. And we have much less work. -- Ilya Loginov <isloginov@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
