IMHO it is certainly a wise choice to have some struct (be it called user_regs_struct or whatever) that describes the exact userland layout. (I think it's also fine to just call that elf_gregset_t and have it be an array, with REG_* defines/enum somewhere to document its indices. It's just a matter of taste for the arch folks.) Given such a struct, the regset code can refer to it (with offsetof, e.g.) and that will make it far easier to read, understand, and review. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html