On Sat, 2009-05-02 at 10:29 -0400, Kyle McMartin wrote: > On Fri, May 01, 2009 at 07:42:21AM -0700, Dave Hansen wrote: > > +#ifndef _PARISC_ASM_PTEMAP_H > > +#define _PARISC_ASM_PTEMAP_H > > + > > +#define pte_offset_map(pmd, address) pte_offset_kernel(pmd, address) > > +#define pte_offset_map_nested(pmd, address) pte_offset_kernel(pmd, address) > > +#define pte_unmap(pte) do { } while (0) > > +#define pte_unmap_nested(pte) do { } while (0) > > + > > +#define pte_unmap(pte) do { } while (0) > > +#define pte_unmap_nested(pte) do { } while (0) > > + > > +#endif /* _PARISC_ASM_PTEMAP_H */ > > You have duplicate definitiosn of pte_unmap{,_nested}? Heh. I actually just copied this verbatim from the existing parisc header. It already had a duplicate. :) Anyway, I've made sure not to copy the dup and added a note in the patch description so that it is much more clear. I'll show up in the next post. Thanks for the review! -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html