Re: [RFC][PATCH 17/35] sparc: create ptemap.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2009-05-02 at 07:02 +0000, Daniel K. wrote:
> Dave Hansen wrote:
> > -/* Certain architectures need to do special things when pte's
> > - * within a page table are directly modified.  Thus, the following
> > - * hook is made available.
> > - */
> 
> This is FUBAR'ed, The comment refers to the BTFIXUPDEF_CALL below, and should not
> be moved to asm/ptemap.h 

Thanks for looking through this.  I've fixed this up in my most recent
version.

> > + * This shortcut works on sun4m (and sun4d) because the nocache area is static,
> > + * and sun4c is guaranteed to have no highmem anyway.
> > + */
> 
> Broken comment.
> 
> > +#define pte_offset_map(d, a)		pte_offset_kernel(d,a)
> > +#define pte_offset_map_nested(d, a)	pte_offset_kernel(d,a)
> > +
> > +#define pte_unmap(pte)		do{}while(0)
> > +#define pte_unmap_nested(pte)	do{}while(0)
> > +
> > +#endif
> > +
> > +#endif /* _SPARC_ASM_PTEMAP_H *//*
> 
> Broken comment.
> 
> I realize this is going away in the end, but all the interim steps should
> compile, to aid bisection.

Yup, absolutely.  This is fixed up now, too.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux