On Thu, Apr 16, 2009 at 08:37:01PM +0200, Sam Ravnborg wrote: > We have discussed privately the possiblity to cover > all of arch/x86/* with -Werror and I came up with some > suggestions so we could cover all subdirectories > with a simple: > > subdir-ccflags-y := -Werror > > I will sent a separate post on this when I have a patch ready.. > > But doing so required us to modify a lot of Makefiles > in arch/x86 - too much for my taste. > > Looking futher I realised that we could move all the core-y > stuff to a separate Kbuild file as done by the appended patch. > We would then cover all the directories with a single: > > subdir-ccflags-y := -Werror > > > This has the added benefit that you can now do: > > make arch/x86/ > > And you will build most (but not all) of the x86 files. > That alone was enough rationale for Ingo to apply it (and I agree). > > What remains are the libs-y and driver-y parts. > There is no way to specify these today. > > If you think this looks wortwhile for your architecture I > will be glad to help cook up a patch - albeit it is trivial > to do so yourself. Most of arch/mips uses -Werror these days and while painful at times it keeps everybody on their toes hopefully cleaner, less buggy code. So if your solution allows adding -Werror to all subdirs automatically with a mechanism to remove -Werror from a few selected dirs then I'm interested. Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
