Hi Michal, Michal Simek wrote:
I would like to say your opinion about putting together Microblaze MMU arch to noMMU version. In C code will be #ifdef CONFIG_MMU ... #endif or #ifndef. Here is proposal for headers. The similar style is used in m68k but I would like to have the same code for both archs in main file. #ifndef _ASM_MICROBLAZE_PAGE_H #define _ASM_MICROBLAZE_PAGE_H code for noMMU and MMU which is the same for both. #ifdef __uClinux__ #include "page_no.h" -> noMMU specific #else #include "page_mm.h"-> MMU specific #endif #endif /* _ASM_MICROBLAZE_PAGE_H */
Breaking up the files that way is really only temporary. They will eventually all be merged back to single files (I have probably reworked about 60% of them so far). There ends up being very little difference. I would keep single files if you could. Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@xxxxxxxxxxxx SnapGear Group, McAfee PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
