On Wed, Oct 15, 2008 at 01:14:45PM +0100, Russell King wrote: > On Wed, Oct 15, 2008 at 02:05:52PM +0200, Martin Schwidefsky wrote: > > Greetings, > > this is the ibcs2/PER_SVR4 removal patch against today git tree. Nobody > > complained so I guess it is ready for prime time. > > Not yet. > > > The question I have is > > by which path should it go upstream? I can certainly create a branch on > > git390 for it but that would be rather unusual since normally only s390 > > related patches go over that repository. Andrew, can you take care of > > it ? > > You're not fixing up all users of SET_PERSONALITY, so this patch is > build-breaking. For example, you're missing the SET_PERSONALITY macro > in arch/arm/include/asm/elf.h. > > Please use 'grep -r' or 'git grep' to find all definitions of this > macro so you can verify if you've hit all of them. His original patch [1] did also fix the ARM one. Looks more like this got accidentally lost when rediffing his patch due to a conflict with your "[ARM] Improve non-executable support" commit? > Russell King cu Adrian [1] http://marc.info/?l=linux-arch&m=122306678613448&w=2 -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html