Re: [patch 179/322] flag parameters add-on: remove epoll_create size param

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 23 Jul 2008, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> Remove the size parameter from the new epoll_create syscall and renames the
> syscall itself.  The updated test program follows.
> 
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> #include <fcntl.h>
> #include <stdio.h>
> #include <time.h>
> #include <unistd.h>
> #include <sys/syscall.h>
> 
> #ifndef __NR_epoll_create2
			   ^
The test program still uses __NR_epoll_create2 instead of
__NR_epoll_create1 everywhere.

> diff -puN fs/eventpoll.c~flag-parameters-add-on-remove-epoll_create-size-param fs/eventpoll.c
> --- a/fs/eventpoll.c~flag-parameters-add-on-remove-epoll_create-size-param
> +++ a/fs/eventpoll.c
> @@ -1046,7 +1046,7 @@ retry:
>   * RB tree. With the current implementation, the "size" parameter is ignored
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   * (besides sanity checks).
      ^^^^^^^^^^^^^^^^^^^^^^^
>   */
> -asmlinkage long sys_epoll_create2(int size, int flags)
> +asmlinkage long sys_epoll_create1(int flags)

The function comment was not updated for the removal of the `size'
parameter. Can you please fix that?

Thanks!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux