On Mon, 2008-04-14 at 12:11 +0100, Russell King wrote: > On Mon, Apr 14, 2008 at 11:32:09AM +0100, David Howells wrote: > > Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote: > > > > > -#ifndef _ASM_UNALIGNED_H > > > -#define _ASM_UNALIGNED_H > > > +#ifndef _ASM_FRV_UNALIGNED_H_ > > > +#define _ASM_FRV_UNALIGNED_H_ > > > > Please don't. Why do you need to change these to make your patch work? > > Indeed - ditto for the ARM changes. The patch is changing them to a > different style to the others in the respective asm/ directories - > which is also different from the linux/ directory. > > IMHO, if Harvey wishes to clean those up, then that should be a separate > patch and should be part of a set converting all includes to use the > same style. > OK, I'll revise without these changes. I am curious what the preferred 'linux' style is (if there is one). Linus, Andrew? Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
