On Mon, Apr 14, 2008 at 11:32:09AM +0100, David Howells wrote: > Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote: > > > -#ifndef _ASM_UNALIGNED_H > > -#define _ASM_UNALIGNED_H > > +#ifndef _ASM_FRV_UNALIGNED_H_ > > +#define _ASM_FRV_UNALIGNED_H_ > > Please don't. Why do you need to change these to make your patch work? Indeed - ditto for the ARM changes. The patch is changing them to a different style to the others in the respective asm/ directories - which is also different from the linux/ directory. IMHO, if Harvey wishes to clean those up, then that should be a separate patch and should be part of a set converting all includes to use the same style. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html