On 8/15/20 11:23 AM, Pascal Bouchareine wrote: > This command attaches the zero terminated string in optval to the > socket for troubleshooting purposes. The free string is displayed in the > process fdinfo file for that fd (/proc/<pid>/fdinfo/<fd>). > > One intended usage is to allow processes to self-document sockets > for netstat and friends to report > > We ignore optlen and constrain the string to a static max size > > 1) You also ignored what would happen at accept() time. Please test your patches with ASAN. 2) Also, why is that description specific to sockets ? 3) When a new socket option is added, it is customary to implement both setsockopt() and getsockopt() for things like CRIU.