Re: [PATCH 32/32] aio: implement io_pgetevents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christoph Hellwig <hch@xxxxxx> writes:

> On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
>> I'd be willing to bet the issue is in your io_syscall6 implementation.
>> You pass in arg5 where arg6 should be used.  Don't feel bad, it took me
>> the better part of today to figure that out.  :)
>> 
>> Here's an incremental diff on top of what you've posted.  Feel free to
>> fold it into your patch (and format however you like).  You can find the
>> libaio changes in my 'aio-poll' branch:
>>   https://pagure.io/libaio/commits/aio-poll
>> 
>> These changes were run through the libaio test harness, 64 bit and 32
>> bit, so the compat system call was tested.
>
> Oops, yes.  Although I prefer the copy_from_user version, this is what
> I had:

Much cleaner.

Thanks!
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux