Re: [RFC PATCH v2 1/3] restartable sequences: user-space per-cpu critical sections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2015-10-27 at 16:56 -0700, Paul Turner wrote:
> 
> + *  flags is currently unused.
> + */
> +SYSCALL_DEFINE3(restartable_sequences,
> +> 	> 	> int, flags, long, event_and_cpu, long, post_commit_instr_addr)
	
> +{
> +	return rseq_configure_current((__user u64 *)event_and_cpu,
> +				      (__user void *)post_commit_instr_addr);

It seems that, for forward compatibility and actually usefulness of the
'flags' argument, you need to reject the syscall if it's passed non-
zero right now. Otherwise applications can (inadvertedly) pass garbage
and you'll not be able to use it in the future.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux