On Thu, Oct 15, 2015 at 07:06:14AM -0400, Sowmini Varadhan wrote:
> On (10/15/15 07:56), Mikko Rapeli wrote:
> > Date: Thu, 15 Oct 2015 07:56:01 +0200
> > From: Mikko Rapeli <mikko.rapeli@xxxxxx>
> > To: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: mikko.rapeli@xxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Sowmini
> > Varadhan <sowmini.varadhan@xxxxxxxxxx>, linux-api@xxxxxxxxxxxxxxx
> > Subject: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64
> > from linux/types.h
> > X-Mailer: git-send-email 2.6.1
> >
> > Fixes userspace compilation errors like:
> >
> > linux/rds.h:96:2: error: unknown type name ‘uint8_t’
>
> Can't you just include <stdint.h> in linux/rds.h? (similar to the
> fix for linux/rds)? It would reduce the deltas significantly,
> and portable applications are likely to expect uint8_t etc anyway.
What kind of portability should exported userspace headers from Linux kernel
need?
Reviews to my previous changes NACKed <stdint.h> usage and
Documentation/CodingStyle chapter 5 says:
(e) Types safe for use in userspace.
In certain structures which are visible to userspace, we cannot
require C99 types and cannot use the 'u32' form above. Thus, we
use __u32 and similar types in all structures which are shared
with userspace.
-Mikko
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
