Hi, On Fri, Sep 25, 2015 at 10:54:09AM -0500, Andreas Dannenberg wrote: > Use the devm_* managed version of the function to register the power > supply and remove the associated unregister function. > > Signed-off-by: Andreas Dannenberg <dannenberg@xxxxxx> > --- > drivers/power/bq24257_charger.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c > index d2d077c..6757b41 100644 > --- a/drivers/power/bq24257_charger.c > +++ b/drivers/power/bq24257_charger.c > @@ -590,8 +590,10 @@ static int bq24257_power_supply_init(struct bq24257_device *bq) > psy_cfg.supplied_to = bq24257_charger_supplied_to; > psy_cfg.num_supplicants = ARRAY_SIZE(bq24257_charger_supplied_to); > > - bq->charger = power_supply_register(bq->dev, &bq24257_power_supply_desc, > - &psy_cfg); > + bq->charger = devm_power_supply_register(bq->dev, > + &bq24257_power_supply_desc, > + &psy_cfg); > + > if (IS_ERR(bq->charger)) > return PTR_ERR(bq->charger); > > @@ -742,8 +744,6 @@ static int bq24257_remove(struct i2c_client *client) > > cancel_delayed_work_sync(&bq->iilimit_setup_work); > > - power_supply_unregister(bq->charger); > - > bq24257_field_write(bq, F_RESET, 1); /* reset to defaults */ This effectively reordering bq24257_field_write() before power_supply_unregister(), so you may want to loose a few words in the patch description, that this is a known/unproblematic side-effect. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
