On Wed, Jul 29, 2015 at 02:30:15PM -0700, Andrew Morton wrote: > On Wed, 29 Jul 2015 19:29:08 +0300 Vladimir Davydov <vdavydov@xxxxxxxxxxxxx> wrote: > > > /proc/kpageidle should probably live somewhere in /sys/kernel/mm, but I > > added it where similar files are located (kpagecount, kpageflags) to > > keep things consistent. > > I think these files should be moved elsewhere. Consistency is good, > but not when we're being consistent with a bad thing. > > So let's place these in /sys/kernel/mm and then start being consistent > with that? I really don't think we should separate kpagecgroup from kpagecount and kpageflags, because they look very similar (each of them is read-only, contains an array of u64 values referenced by PFN). Scattering these files between different filesystems would look ugly IMO. However, kpageidle is somewhat different (it's read-write, contains a bitmap) so I think it's worth moving it to /sys/kernel/mm. We have to move the code from fs/proc to mm/something then to remove dependency from PROC_FS, which would be unnecessary. Let me give it a try. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
