On Wed, Jul 29, 2015 at 02:36:30PM +0200, Michal Hocko wrote: > On Sun 19-07-15 15:31:09, Vladimir Davydov wrote: > [...] > > ---- USER API ---- > > > > The user API consists of two new proc files: > > I was thinking about this for a while. I dislike the interface. It is > quite awkward to use - e.g. you have to read the full memory to check a > single memcg idleness. This might turn out being a problem especially on > large machines. Yes, with this API estimating the wss of a single memory cgroup will cost almost as much as doing this for the whole system. Come to think of it, does anyone really need to estimate idleness of one particular cgroup? If we are doing this for finding an optimal memcg limits configuration or while considering a load move within a cluster (which I think are the primary use cases for the feature), we must do it system-wide to see the whole picture. > It also provides a very low level information (per-pfn idleness) which > is inherently racy. Does anybody really require this level of detail? Well, one might want to do it per-process, obtaining PFNs from /proc/pid/pagemap. > > I would assume that most users are interested only in a single number > which tells the idleness of the system/memcg. Yes, that's what I need it for - estimating containers' wss for setting their limits accordingly. > Well, you have mentioned a per-process reclaim but I am quite > skeptical about this. This is what Minchan mentioned initially. Personally, I'm not going to use it per-process, but I wouldn't rule out this use case either. > > I guess the primary reason to rely on the pfn rather than the LRU walk, > which would be more targeted (especially for memcg cases), is that we > cannot hold lru lock for the whole LRU walk and we cannot continue > walking after the lock is dropped. Maybe we can try to address that > instead? I do not think this is easy to achieve but have you considered > that as an option? Yes, I have, and I've come to a conclusion it's not doable, because LRU lists can be constantly rotating at an arbitrary rate. If you have an idea in mind how this could be done, please share. Speaking of LRU-vs-PFN walk, iterating over PFNs has its own advantages: - You can distribute a walk in time to avoid CPU bursts. - You are free to parallelize the scanner as you wish to decrease the scan time. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
