On 06/17/2015 12:12 PM, Kees Cook wrote: > On Wed, Jun 17, 2015 at 12:31 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: >> On Tue, 2015-06-16 at 10:54 -0700, Kees Cook wrote: >>> This imports the existing seccomp test suite into the kernel's selftests >>> tree. It contains extensive testing of seccomp features and corner cases. >>> There remain additional tests to move into the kernel tree, but they have >>> not yet been ported to all the architectures seccomp supports: >>> https://github.com/redpig/seccomp/tree/master/tests >>> >>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> >>> --- >>> MAINTAINERS | 1 + >>> tools/testing/selftests/Makefile | 1 + >>> tools/testing/selftests/seccomp/.gitignore | 1 + >>> tools/testing/selftests/seccomp/Makefile | 10 + >>> tools/testing/selftests/seccomp/seccomp_bpf.c | 2109 ++++++++++++++++++++++++ >>> tools/testing/selftests/seccomp/test_harness.h | 537 ++++++ >> >> >> Thanks very much for adding this, it would have been very helpful recently when >> I was trying to get seccomp filter working on powerpc :) >> >> I get one failure in TRACE_syscall.syscall_dropped: >> >> seccomp_bpf.c:1394:TRACE_syscall.syscall_dropped:Expected 1 (1) == syscall(207) (18446744073709551615) >> >> >> So it looks like we're returning -1 instead of 1. >> >> That's probably a bug in our handling of the return value, or maybe an >> inconsistency across the arches. I'll try and find time to dig into it. > > Ah-ha! Excellent. Did you add an implementation for change_syscall() > in seccomp_bpf.c? I don't have a powerpc method in there. I would have > expected both TRACE_syscall.syscall_redirected and .syscall_dropped to > fail without that. > > If you did, maybe something isn't right with regs.SYSCALL_RET ? That's > where the return value being tested on a skipped syscall is stored. > > Thanks for testing! > Thanks for the test. Fantastic to see so many positive responses to this addition. Thanks Michael for testing it. It is now queued for 4.2 in linux-kselftest next thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
