On Mon, Jun 30, 2014 at 10:47 PM, Alexei Starovoitov <ast@xxxxxxxxxxxx> wrote: > On Mon, Jun 30, 2014 at 3:09 PM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote: >> On Sat, Jun 28, 2014 at 11:36 PM, Alexei Starovoitov <ast@xxxxxxxxxxxx> wrote: >>> On Sat, Jun 28, 2014 at 6:52 PM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote: >>>> On Sat, Jun 28, 2014 at 1:49 PM, Alexei Starovoitov <ast@xxxxxxxxxxxx> wrote: >>>>> >>>>> Sorry I don't like 'fd' direction at all. >>>>> 1. it will make the whole thing very socket specific and 'net' dependent. >>>>> but the goal here is to be able to use eBPF for tracing in embedded >>>>> setups. So it's gotta be net independent. >>>>> 2. sockets are already overloaded with all sorts of stuff. Adding more >>>>> types of sockets will complicate it a lot. >>>>> 3. and most important. read/write operations on sockets are not >>>>> done every nanosecond, whereas lookup operations on bpf maps >>>>> are done every dozen instructions, so we cannot have any overhead >>>>> when accessing maps. >>>>> In other words the verifier is done as static analyzer. I moved all >>>>> the complexity to verify time, so at run-time the programs are as >>>>> fast as possible. I'm strongly against run-time checks in critical path, >>>>> since they kill performance and make the whole approach a lot less usable. >>>> >>>> I may have described my suggestion poorly. I'm suggesting that all of >>>> these global ids be replaced *for userspace's benefit* with fds. That >>>> is, a map would have an associated struct inode, and, when you load an >>>> eBPF program, you'd pass fds into the kernel instead of global ids. >>>> The kernel would still compile the eBPF program to use the global ids, >>>> though. >>> >>> Hmm. If I understood you correctly, you're suggesting to do it similar >>> to ipc/mqueue, shmem, sockets do. By registering and mounting >>> a file system and providing all superblock and inode hooks… and >>> probably have its own namespace type… hmm… may be. That's >>> quite a bit of work to put lightly. As I said in the other email the first >>> step is root only and all these complexity just not worth doing >>> at this stage. >> >> The downside of not doing it right away is that it's harder to >> retrofit in without breaking early users. >> >> You might be able to get away with using anon_inodes. That will > > Spent quite a bit of time playing with anon_inode_getfd(). The model > works ok for seccomp, but doesn't seem to work for tracing, > since tracepoints are global. Say, syscall(bpf, load_prog) returns > a process-local fd. This 'fd' as a string can be written to > debugfs/tracing/events/.../filter which will increment a refcnt of a global > ebpf_program structure and will keep using it. When process exits it will > close all fds which in case of ebpf_prog_fd should be a nop, since > the program is still attached to a global event. Now we have a > program and maps that still alive and dangling, since tracepoint events > keep coming, but no new process can access it. Here we just lost all > benefits of making it 'fd' based. Theoretically we can extend tracing to > be fd-based too and tracepoints will auto-detach upon process exit, > but that's not going to work for all other global events. Like networking > components (bridge, ovs, …) are global and they won't be adding > fd-based interfaces. > I'm still thinking about it, but it looks like that any process-local > ebpf_prog_id scheme is not going to work for global events. Thoughts? Hmm. Maybe these things do need global ids for tracing, or at least there need to be some way to stash them somewhere and find them again. I suppose that debugfs could have symlinks to them, but I don't know how hard that would be to implement or how awkward it would be to use. I imagine there's some awkwardness regardless. For tracing, if I create map 75 and eBPF program 492 that uses map 75, then I still need to remember that map 75 is the map I want (or I need to parse the eBPF program later on). How do you imagine the userspace code working? Maybe it would make sense to add some nlattrs for eBPF programs to map between referenced objects and nicknames for them. Then user code could look at /sys/kernel/debug/whatever/nickname_of_map to resolve the map id or even just open it directly. I admit that I'm much more familiar with seccomp and even socket filters than I am with tracing. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
