On Mon, Nov 08, 2010 at 12:32:47PM -0800, Mike Waychison wrote: >As preparation for moving netpoll_targets out of netconsole and making >them available to other clients, introduce new Kconfig options. > >CONFIG_NETPOLL_TARGETS > >Access to targets APIs. Only supports parameter based parsing of >targets (via the kernel command line or module paramters). > >CONFIG_NETPOLL_TARGETS_DYNAMIC > >Extends the support that netpoll_targets provides by allowing for the >dynamic creation of targets in configfs on a per client basis. > >Signed-off-by: Mike Waychison <mikew@xxxxxxxxxx> >--- > drivers/net/Kconfig | 16 +++++++++++++--- > drivers/net/netconsole.c | 10 +++++----- > 2 files changed, 18 insertions(+), 8 deletions(-) > >diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig >index f6668cd..b014cd6 100644 >--- a/drivers/net/Kconfig >+++ b/drivers/net/Kconfig >@@ -3367,14 +3367,15 @@ config NET_FC > > config NETCONSOLE > tristate "Network console logging support" >+ select NETPOLL_TARGETS > ---help--- > If you want to log kernel messages over the network, enable this. > See <file:Documentation/networking/netconsole.txt> for details. > > config NETCONSOLE_DYNAMIC > bool "Dynamic reconfiguration of logging targets" >- depends on NETCONSOLE && SYSFS >- select CONFIGFS_FS >+ depends on NETCONSOLE >+ select NETPOLL_TARGETS_DYNAMIC > help > This option enables the ability to dynamically reconfigure target > parameters (interface, IP addresses, port numbers, MAC addresses) >@@ -3382,7 +3383,16 @@ config NETCONSOLE_DYNAMIC > See <file:Documentation/networking/netconsole.txt> for details. > > config NETPOLL >- def_bool NETCONSOLE >+ def_bool false >+ >+config NETPOLL_TARGETS >+ bool >+ select NETPOLL >+ >+config NETPOLL_TARGETS_DYNAMIC >+ bool >+ select CONFIGFS_FS >+ select NETPOLL_TARGETS > Hey, have you tried CONFIG_CONFIGFS_FS=m? :) Actually, I tried almost the same thing, but finally failed due to CONFIG_CONFIGFS_FS=m. NETPOLL can't be a module, and configfs can be, thus you can't use the API provided by configfs. So, either we need to de-modulize configfs or replace configfs API with sysfs API. Personally, I prefer the former one, I don't think configfs should be a module as long as it can provide API's for other subsystems, like debugfs. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
